Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Update replication nav #24283

Merged
merged 15 commits into from
Dec 4, 2023
Merged

UI: Update replication nav #24283

merged 15 commits into from
Dec 4, 2023

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Nov 28, 2023 •
edited
Loading

Adds replication sub-nav to replication engine (and some glimmerization/cleanup on the card component)
Replication overview with new nav

Replication is now all under "Monitoring":
Main nav

Also did some cleanup while I was in the area:
HDS Cards
HDS Buttons

@hashishaw hashishaw added the ui label Nov 28, 2023
@hashishaw hashishaw added this to the 1.16.0-rc1 milestone Nov 28, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 28, 2023
@hashishaw hashishaw marked this pull request as ready for review November 29, 2023 20:01
hashishaw
hashishaw commented Nov 29, 2023
View reviewed changes
ui/app/app.js
'router',
'store',
'version',
'-portal',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was required to get the subnav rendering within an engine

@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

hashishaw
hashishaw commented Nov 29, 2023
View reviewed changes
ui/lib/core/addon/components/replication-summary-card.hbs
SPDX-License-Identifier: BUSL-1.1
~}}

<Hds::Card::Container
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to components folder and used HDS cards

zofskeez
zofskeez reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a code perspective. I'll pull down the branch and do some testing as well.

ui/lib/core/addon/components/replication-summary-card.js Outdated Show resolved Hide resolved
zofskeez
zofskeez approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled down the branch and everything looks good to me. Nice improvement having a sub nav for replication! Thanks for the updates 🎉

@hashishaw hashishaw merged commit af3901e into main Dec 4, 2023
71 checks passed
@hashishaw hashishaw deleted the ui/replication-nav branch December 4, 2023 16:40
@Monkeychip Monkeychip mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zofskeez zofskeez zofskeez approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.16.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@hashishaw @zofskeez