Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Correct the post-unseal meaning of the seal status type into release/1.15.x #24170

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core commented Nov 16, 2023

Backport

This PR is auto-generated from #23022 to be assessed for backporting due to the inclusion of the label backport/1.15.x.

The below text is copied from the body of the original PR.


And at the same time add a RecoverySealType to the response which preserves the old meaning.
Updated the CLI to display both when relevant.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/sgm/vault-7061/correct-seal-status-types/quickly-informed-gopher branch from a81ec92 to afa2bb3 Compare November 16, 2023 19:30
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 16, 2023
* Correct the post-unseal meaning of the seal status type

And at the same time add a RecoverySealType to the response which preserves the old meaning.
Updated the CLI to display both when relevant.

* changelog

* no longer needed

* Don't need this field either, which fixes unit tests

* fix unit tests
@victorr victorr force-pushed the backport/sgm/vault-7061/correct-seal-status-types/quickly-informed-gopher branch from c07005f to f5dd113 Compare November 16, 2023 19:43
@victorr
Copy link
Contributor

victorr commented Nov 16, 2023

I have fixed a minor conflict and updated the PR.

@victorr victorr added this to the 1.15.3 milestone Nov 16, 2023
@victorr victorr self-assigned this Nov 16, 2023
@victorr victorr marked this pull request as ready for review November 16, 2023 19:45
@victorr victorr requested a review from a team November 16, 2023 19:53
Copy link

Build Results:
All builds succeeded! ✅

@victorr victorr merged commit caf03e4 into release/1.15.x Nov 16, 2023
95 checks passed
@victorr victorr deleted the backport/sgm/vault-7061/correct-seal-status-types/quickly-informed-gopher branch November 16, 2023 20:10
Copy link

CI Results:
All Go tests succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants