UI: always send capabilities-self request in user's root namespace #24168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
hashishaw
commented
Nov 16, 2023
| * @param {string} rootPath eg apps/prod | ||
| * @returns the leftover segment, eg app_1/test | ||
| */ | ||
| export function getRelativePath(fullPath = '', rootPath = '') { |
There was a problem hiding this comment.
I initially had this logic within the namespace computed property, but it was much easier to test as a util
|
Build Results: |
zofskeez
approved these changes
Nov 20, 2023
hashishaw
deleted the
VAULT-21375/capabilities-self-always-with-user-root
branch
hashishaw
added a commit
that referenced
this pull request
Nov 20, 2023
…24168) * Add getRelativePath helper and use to calculate relativeNamespace * Always request capabilities-self on users root ns and prefix body with relative path * Update capabilities adapter with test * add changelog * Simplify getRelativePath logic * test update
fopina-ci
pushed a commit
to fopina/vault
that referenced
this pull request
Dec 1, 2023
…ashicorp#24168) (hashicorp#24204) * Add getRelativePath helper and use to calculate relativeNamespace * Always request capabilities-self on users root ns and prefix body with relative path * Update capabilities adapter with test * add changelog * Simplify getRelativePath logic * test update
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sys/capabilities-selfis an endpoint the UI uses to surface actions that a user can take within the GUI. The endpoint is on the default policy so that users can by default use the UI in the intended way.However, the policy is only applicable to the namespace where the user's auth mount is, so a user with the default policy only who logs into a child namespace that they have access to might see an error related to capabilities-self, or erroneously see buttons for actions they don't have capabilities to perform.
This PR fixes that experience by ensuring the capabilities-self endpoint is always queried on the user's root namespace, and adds the rest of the current namespace to the beginning of the queried path.