UI: helper sort-objects to alphabetize list items #24103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
hashishaw
reviewed
Nov 13, 2023
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| <Identity::EntityNav @identityType={{this.identityType}} @model={{this.model}} /> | |||
| {{#if this.model.meta.total}} | |||
| {{#each this.model as |item|}} | |||
| {{#each (sort-objects this.model "name") as |item|}} | |||
There was a problem hiding this comment.
I think we'll want to sort in lazyPaginatedQuery instead, otherwise this will only sort the items on the current page
hashishaw
reviewed
Nov 13, 2023
| @@ -4,4 +4,29 @@ | |||
| */ | |||
|
|
|||
| import IdentitySerializer from './_base'; | |||
| export default IdentitySerializer.extend(); | |||
| export default IdentitySerializer.extend({ | |||
| extractLazyPaginatedData(payload) { | |||
There was a problem hiding this comment.
We have to serialize the data here so that the information is sortable by name in lazyPaginatedQuery
…t metadata shows on list
hashishaw
reviewed
Nov 13, 2023
| export default IdentitySerializer.extend({ | ||
| extractLazyPaginatedData(payload) { | ||
| return payload.data.keys.map((key) => { | ||
| const model = payload.data.key_info[key]; |
There was a problem hiding this comment.
Used the same logic that's in the IdentitySerializer's normalizeItems method so we still have metadata on the list
This was referenced Nov 14, 2023
hashishaw
added a commit
that referenced
this pull request
Nov 15, 2023
* move list to component * use helper instead * add changelog * clarify changelog copy * delete components now that helper is in use * move helper to util, remove template helper invokation * add optional sorting to lazyPaginatedQuery based on sortBy query attribute * Add serialization to entity-alias and entity so that they can be sorted by name on list view * Same logic as base normalizeItems for extractLazyPaginatedData so that metadata shows on list * Add headers --------- Co-authored-by: Chelsea Shaw <[email protected]> Co-authored-by: Chelsea Shaw <[email protected]>
hashishaw
added a commit
that referenced
this pull request
Nov 15, 2023
* move list to component * use helper instead * add changelog * clarify changelog copy * delete components now that helper is in use * move helper to util, remove template helper invokation * add optional sorting to lazyPaginatedQuery based on sortBy query attribute * Add serialization to entity-alias and entity so that they can be sorted by name on list view * Same logic as base normalizeItems for extractLazyPaginatedData so that metadata shows on list * Add headers --------- Co-authored-by: Chelsea Shaw <[email protected]> Co-authored-by: Chelsea Shaw <[email protected]>
This was referenced Nov 15, 2023
hashishaw
added a commit
that referenced
this pull request
Nov 15, 2023
* move list to component * use helper instead * add changelog * clarify changelog copy * delete components now that helper is in use * move helper to util, remove template helper invokation * add optional sorting to lazyPaginatedQuery based on sortBy query attribute * Add serialization to entity-alias and entity so that they can be sorted by name on list view * Same logic as base normalizeItems for extractLazyPaginatedData so that metadata shows on list * Add headers --------- Co-authored-by: claire bontempo <[email protected]>
hashishaw
added a commit
that referenced
this pull request
Nov 15, 2023
* move list to component * use helper instead * add changelog * clarify changelog copy * delete components now that helper is in use * move helper to util, remove template helper invokation * add optional sorting to lazyPaginatedQuery based on sortBy query attribute * Add serialization to entity-alias and entity so that they can be sorted by name on list view * Same logic as base normalizeItems for extractLazyPaginatedData so that metadata shows on list * Add headers ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14176 by sorting models using a new helper
sort-objectsin the hbs templatebefore