fix log_requests_level misconfiguration
#24056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteski22
added
bug
github-actions
bot
added
the
hashicorp-contributed-pr
peteski22
commented
Nov 8, 2023
| // Log level | ||
| c.configureLogRequestLevel(conf.RawConfig.LogLevel) | ||
| // Log requests level | ||
| c.configureLogRequestsLevel(conf.RawConfig.LogRequestsLevel) |
There was a problem hiding this comment.
This is the actual fix (supplying LogRequestsLevel instead of LogLevel), the rest of the PR is tidy up.
|
Build Results: |
|
CI Results: |
peteski22
pushed a commit
that referenced
this pull request
Nov 8, 2023
peteski22
pushed a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactoring change introduced a bug where the incorrect value (log level rather than log requests level) is suppled to the receiver which configures the log requests level on a Core.
Fixes: #24045