Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of VAULT-19328: Replace nytimes/gziphandler With klauspost/compress/gzhttp into release/1.13.x #23961

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #23898 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@marcboudreau
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


The github.com/nytimes/gziphandler package appears to no longer be maintained. The github.com/klauspost/compress/gzhttp package is an actively maintained fork of the former.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/marcboudreau/VAULT-19328/replace-gziphandler-package/specially-witty-bug branch from 65fdb18 to 2f510cc Compare November 2, 2023 14:44
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 2, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

CI Results:
All Go tests succeeded! ✅

@marcboudreau marcboudreau force-pushed the backport/marcboudreau/VAULT-19328/replace-gziphandler-package/specially-witty-bug branch from a24a64c to 207c490 Compare November 2, 2023 20:24
@marcboudreau marcboudreau marked this pull request as ready for review November 2, 2023 20:24
@marcboudreau marcboudreau force-pushed the backport/marcboudreau/VAULT-19328/replace-gziphandler-package/specially-witty-bug branch from 207c490 to 83846b5 Compare November 2, 2023 20:27
@marcboudreau marcboudreau added this to the 1.13.10 milestone Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

Build Results:
All builds succeeded! ✅

@marcboudreau marcboudreau merged commit fa61a0b into release/1.13.x Nov 2, 2023
98 of 99 checks passed
@marcboudreau marcboudreau deleted the backport/marcboudreau/VAULT-19328/replace-gziphandler-package/specially-witty-bug branch November 2, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants