UI: chroot namespace listener #23942
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
| standby: attr('boolean'), | ||
| isActive: equal('standby', false), | ||
| clusterName: attr('string'), |
There was a problem hiding this comment.
clusterName isn't used anywhere, so removed it from the model. The other values are also available on seal-status which will be available in a chroot scenario, so I moved those below to that section
| @@ -44,7 +44,7 @@ export default class VersionService extends Service { | |||
| @task | |||
| *getVersion() { | |||
| if (this.version) return; | |||
| const response = yield this.store.adapterFor('cluster').health(); | |||
| const response = yield this.store.adapterFor('cluster').sealStatus(); | |||
There was a problem hiding this comment.
Getting version from this endpoint instead since it's available in non-root namespace.
There was a problem hiding this comment.
This will probably be updated again to a UI-specific endpoint in the near future, but this will do for now.
ui/app/templates/error.hbs
Outdated
There was a problem hiding this comment.
Since the error was happening in the cluster route, we needed to add this highest-level error template to show the error.
There was a problem hiding this comment.
There are subtle bugs introduced when you use {{@model}} instead of {{this.model}} in route templates -- https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-model-argument-in-route-templates.md
This route isn't problematic since it doesn't use route params, but in terms of best practices we should make route templates consistently use this.model
Shoutout to @fivetanley for sharing this knowledge (shamelessly stole your language)
| ? `Vault v${versionName.slice(0, versionName.indexOf('+'))} root` | ||
| : `Vault v${versionName}`; | ||
|
|
||
| assert.dom(SELECTORS.cardHeader('Vault version')).hasText(versionText); |
There was a problem hiding this comment.
Updated this test because the root namespace badge shouldn't show in community version
|
Build Results: |
This PR consists of updates to make the UI usable when chroot namespace listener is set.
When accessing the UI via a listener where chroot_namespace is set, but the defined namespace does not exist, the UI will show an error:
Otherwise, the UI should work normally*