Add HCP subcommand -- integrate with HCP library #23897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biazmoreira
changed the title
github-actions
bot
added
the
hashicorp-contributed-pr
ncabatoff
reviewed
Oct 30, 2023
ncabatoff
reviewed
Oct 30, 2023
biazmoreira
force-pushed
the
biazmoreira/hcp/en
branch
from
7fae6f7 to
27fe0c0
Compare
biazmoreira
force-pushed
the
biazmoreira/hcp/en
branch
from
27fe0c0 to
3871ade
Compare
biazmoreira
force-pushed
the
biazmoreira/hcp/en
branch
from
3871ade to
197d082
Compare
|
CI Results: |
biazmoreira
force-pushed
the
biazmoreira/hcp/en
branch
from
197d082 to
8b7294c
Compare
ccapurso
reviewed
Oct 31, 2023
biazmoreira
force-pushed
the
biazmoreira/hcp/en
branch
from
8b7294c to
04d1162
Compare
biazmoreira
force-pushed
the
biazmoreira/hcp/en
branch
from
04d1162 to
17ae8fa
Compare
biazmoreira
force-pushed
the
biazmoreira/hcp/en
branch
from
17ae8fa to
9e0c1d3
Compare
biazmoreira
force-pushed
the
biazmoreira/hcp/en
branch
from
9e0c1d3 to
7a0fb4c
Compare
biazmoreira
force-pushed
the
biazmoreira/hcp/en
branch
from
7a0fb4c to
8184cc9
Compare
schavis
requested changes
Nov 13, 2023
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Yoko Hyakuna <[email protected]>
Co-authored-by: Yoko Hyakuna <[email protected]>
Co-authored-by: Yoko Hyakuna <[email protected]>
Co-authored-by: Yoko Hyakuna <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
Co-authored-by: Sarah Chavis <[email protected]>
biazmoreira
force-pushed
the
biazmoreira/hcp/en
branch
from
b756e15 to
3d9745e
Compare
ncabatoff
approved these changes
Jan 9, 2024
mladlow
reviewed
Mar 11, 2024
| @@ -0,0 +1,4 @@ | |||
| ```release-note:feature | |||
| cli: introduce new command group hcp which groups subcommands for authentication of users or machines to HCP using | |||
There was a problem hiding this comment.
@biazmoreira next time please use the correct new feature formatting for new features in the changelog.
There was a problem hiding this comment.
To add some more clarification - this should use the "Feature Name" we'd use in the release notes, and should try to communicate to the user why they would want to learn more about this brand new feature we're introducing in Vault 1.16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate new HCP library and its command group