Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix panic when unlocking unlocked user into release/1.15.x #23613

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #23611 to be assessed for backporting due to the inclusion of the label backport/1.15.x.

The below text is copied from the body of the original PR.


This PR fixes a panic when attempting to unlock an already unlocked user.

Example Panic:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x380c80a]

goroutine 147274 [running]:
github.com/hashicorp/vault/vault.unlockUser({0xa434c80, 0xc00fa6aeb0}, 0xc00ef26900, {0xc00e8cfb11, 0x16}, {0xc00e8cfb2f, 0x6})
	/home/runner/actions-runner/_work/vault-enterprise/vault-enterprise/vault/logical_system_user_lockout.go:61 +0x28a
github.com/hashicorp/vault/vault.(*SystemBackend).handleUnlockUser(0xc005b7e740, {0xa434c80, 0xc00fa6aeb0}, 0x0?, 0xffffffffffffffff?)
	/home/runner/actions-runner/_work/vault-enterprise/vault-enterprise/vault/logical_system.go:2492 +0x27b
github.com/hashicorp/vault/sdk/framework.(*Backend).HandleRequest(0xc011fbd770, {0xa434c80, 0xc00fa6aeb0}, 0xc023034fc0)
	/home/runner/actions-runner/_work/vault-enterprise/vault-enterprise/sdk/framework/backend.go:310 +0xa88

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/davidadeleon/fix-lockout-log-panic/obviously-concise-kid branch from aa322dd to 7d51eed Compare October 11, 2023 17:00
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 11, 2023
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@davidadeleon davidadeleon merged commit 5a6a777 into release/1.15.x Oct 11, 2023
98 of 99 checks passed
@davidadeleon davidadeleon deleted the backport/davidadeleon/fix-lockout-log-panic/obviously-concise-kid branch October 11, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants