Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OktaNumberChallenge #23565

Merged
merged 8 commits into from
Oct 11, 2023
Merged

Fix OktaNumberChallenge #23565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
858a9b3
remove arg
Monkeychip Oct 8, 2023
e383f83
changelog
Monkeychip Oct 8, 2023
0ac1850
Merge branch 'main' into ui/VAULT-20694/fix-okta-number-challenge
Monkeychip Oct 9, 2023
753b541
Merge branch 'main' into ui/VAULT-20694/fix-okta-number-challenge
Monkeychip Oct 9, 2023
c62c0f0
Merge branch 'main' into ui/VAULT-20694/fix-okta-number-challenge
Monkeychip Oct 10, 2023
636dd84
Merge branch 'main' into ui/VAULT-20694/fix-okta-number-challenge
Monkeychip Oct 10, 2023
147d006
Merge branch 'main' into ui/VAULT-20694/fix-okta-number-challenge
Monkeychip Oct 11, 2023
4f4c675
Merge branch 'main' into ui/VAULT-20694/fix-okta-number-challenge
Monkeychip Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/23565.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
ui: Fix regression that broke the oktaNumberChallenge on the ui.
```
4 changes: 2 additions & 2 deletions ui/app/components/auth-form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ export default Component.extend(DEFAULTS, {
return;
}
let response = null;
this.args.setOktaNumberChallenge(true);
this.setOktaNumberChallenge(true);
this.setCancellingAuth(false);
// keep polling /auth/okta/verify/:nonce API every 1s until a response is given with the correct number for the Okta Number Challenge
while (response === null) {
Expand Down Expand Up @@ -332,7 +332,7 @@ export default Component.extend(DEFAULTS, {
});
},
returnToLoginFromOktaNumberChallenge() {
this.args.setOktaNumberChallenge(false);
this.setOktaNumberChallenge(false);
this.set('oktaNumberChallengeAnswer', null);
},
},
Expand Down
Loading