Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Policies Error Route into release/1.15.x #23525

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #23516 to be assessed for backporting due to the inclusion of the label backport/1.15.x.

The below text is copied from the body of the original PR.


This PR adds an error route for policies to allow for the policy navigation links to show if the route transition errors. Interestingly enough the error was bubbling up to the cluster.error route which I would expect that the cluster navigation links would display but for some reason no links were rendering.

image

In any case we want the policy links to render in the case of an error so adding the error route template was necessary.

image


Overview of commits

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 5, 2023
@zofskeez zofskeez added this to the 1.15.1 milestone Oct 5, 2023
@zofskeez zofskeez added the ui label Oct 5, 2023
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-20722/policies-error-route/certainly-amused-garfish branch from ed66e67 to d5d8bd1 Compare October 5, 2023 15:31
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

CI Results:
All Go tests succeeded! ✅

@zofskeez zofskeez merged commit 745807b into release/1.15.x Oct 5, 2023
101 of 102 checks passed
@zofskeez zofskeez deleted the backport/ui/VAULT-20722/policies-error-route/certainly-amused-garfish branch October 5, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants