Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: [VAULT-20626] Hide replication if user doesnt have permissions #23452

Merged
merged 4 commits into from
Oct 3, 2023
Merged

UI: [VAULT-20626] Hide replication if user doesnt have permissions #23452

merged 4 commits into from
Oct 3, 2023

Conversation

kiannaquach
Copy link
Contributor

Description
Hides replication card if the user doesn't have permissions to view the card.

@kiannaquach kiannaquach added this to the 1.15.1 milestone Oct 2, 2023
@vercel
Copy link

vercel bot commented Oct 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
vault ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2023 3:25pm

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 2, 2023
@kiannaquach kiannaquach marked this pull request as ready for review October 3, 2023 14:27
hashishaw
hashishaw approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Again, can we get test coverage? And this feels similarly scoped to dashboard permissions updates, maybe we can just lump it in with your other PR?

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Build Results:
All builds succeeded! ✅

@kiannaquach kiannaquach mentioned this pull request Oct 3, 2023
Merged
@kiannaquach
Copy link
Contributor Author

Tests added here for hiding replication card and configuration details (PR #23394)

@kiannaquach kiannaquach merged commit c2952e3 into main Oct 3, 2023
@kiannaquach kiannaquach deleted the ui/VAULT-20626/hide-replication-card branch October 3, 2023 15:54
Merged
hellobontempo pushed a commit that referenced this pull request Oct 3, 2023
@kiannaquach @hellobontempo
UI: [VAULT-20626] Hide replication if user doesnt have permissions (#…
e51314d 
…23452)
@kiannaquach kiannaquach mentioned this pull request Oct 6, 2023
Merged
Closed
@kiannaquach kiannaquach mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashishaw hashishaw hashishaw approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Milestone
1.15.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kiannaquach @hashishaw