-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: [VAULT-19783] Set up root token warning modal #23277
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
7c27340
Set up root token warning modal
kiannaquach 742f147
Get current namespace path name
kiannaquach 5aaf409
Add changelog
kiannaquach 2bb0b2f
Fix tests
kiannaquach 3d64360
Fix more test failures
kiannaquach bb9dc53
Merge branch 'main' into ui/VAULT-19783/root-token-warning-modal
kiannaquach a122c95
Remove close button
kiannaquach eb7557c
Merge branch 'main' into ui/VAULT-19783/root-token-warning-modal
kiannaquach ff1447e
Update namespace service prop name and remove click test
kiannaquach 1dd002a
Merge branch 'main' into ui/VAULT-19783/root-token-warning-modal
kiannaquach dd406c9
Put flash message and come up with warning
kiannaquach e821659
Merge branch 'main' into ui/VAULT-19783/root-token-warning-modal
kiannaquach 10266a6
Add conditional for root token
kiannaquach 1b577d6
Merge branch 'main' into ui/VAULT-19783/root-token-warning-modal
kiannaquach ce2a6c5
Merge branch 'main' into ui/VAULT-19783/root-token-warning-modal
kiannaquach 909acaf
Remove sticky flash message
kiannaquach f0ba3a1
Update changelog
kiannaquach d5022d5
Merge branch 'main' into ui/VAULT-19783/root-token-warning-modal
kiannaquach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:improvement | ||
ui: Add warning message to the namespace picker warning users about the behavior when logging in with a root token. | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opted to follow what's being done in the user menu dropdown see here. hen we use
AlertInline
, with typewarning
the icon looks really small and styling gets a little wonky and with typecompact
the namespace picker dropdown gets pulled to the top (see attached images).