UI: add warning before downloading secret data #23260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
commented
Sep 22, 2023
| @stringify={{true}} | ||
| aria-label="Download secret value" | ||
| {{on "click" (fn (mut this.modalOpen) false)}} |
There was a problem hiding this comment.
@zofskeez - There's a click event in the <DownloadButton> that handles the eventual download. It works fine locally but do you foresee any issue with stacking events like this?
There was a problem hiding this comment.
I think it would be better to pass the action up from the handleDownload method in DownloadButton. Something like:
async handleDownload() {
try {
// download was a success
if (this.args.onSuccess) {
this.args.onSuccess();
}
} catch {}
}There was a problem hiding this comment.
Yes! That's what I was thinking 🤔 Will refactor!
|
Build Results: |
|
CI Results: |
This was referenced Sep 22, 2023
This was referenced Sep 22, 2023
zofskeez
reviewed
Sep 22, 2023
|
|
||
| <div id="qunit"></div> | ||
| <div id="qunit-fixture"> | ||
| <div id="ember-testing-container"> | ||
| <div id="ember-testing"></div> | ||
| <div id="modal-wormhole"></div> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #20431 we added the ability to download a secret value. To prevent accidentally downloading sensitive data, we've added a confirmation modal prompting users to cancel or proceed with the download.
🎥