UI: Adds tidy_revoked_certs and revoked_cert_deleted_count to PKI tidy status page #23232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
changed the title
hellobontempo
commented
Sep 21, 2023
There was a problem hiding this comment.
Organized params a bit so it's easier to follow what goes where
hellobontempo
commented
Sep 21, 2023
| @@ -57,24 +60,26 @@ export default class PkiTidyStatusComponent extends Component<Args> { | |||
| tidyStatusGeneralFields = [ | |||
| 'time_started', | |||
| 'time_finished', | |||
| 'last_auto_tidy_finished', | |||
There was a problem hiding this comment.
This param doesn't behave as expected. It behaves similarly to time_finished, and isn't specific to auto-tidying
hellobontempo
changed the title
hellobontempo
commented
Sep 21, 2023
| ]; | ||
|
|
||
| tidyStatusConfigFields = [ | ||
| 'tidy_cert_store', | ||
| 'tidy_revocation_queue', |
There was a problem hiding this comment.
duplicate (enterprise only, below) - this should have originally been tidy_revoked_certs
hellobontempo
commented
Sep 21, 2023
| ]; | ||
|
|
||
| tidyStatusConfigFields = [ | ||
| 'tidy_cert_store', | ||
| 'tidy_revocation_queue', | ||
| 'tidy_cross_cluster_revoked_certs', |
There was a problem hiding this comment.
enterprise only (moved below)
hellobontempo
commented
Sep 21, 2023
| 'missing_issuer_cert_count', | ||
| 'revocation_queue_deleted_count', |
There was a problem hiding this comment.
enterprise only moved below to crossClusterOperation array
|
Build Results: |
|
CI Results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes duplicate
tidy_revocation_queuewhich should have beentidy_revoked_certs