Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GET for plugin runtime listing #23171

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Sep 19, 2023

vault plugin runtime list (correctly) uses a GET method to list plugin runtimes, but the API only supported LIST.

Also corrects the error code for reading a non-existent plugin runtime from 500 -> 404.

Also corrects the error code for reading a non-existent plugin runtime
from 500 -> 404
@tomhjp tomhjp added bug Used to indicate a potential bug backport/1.15.x labels Sep 19, 2023
@tomhjp tomhjp added this to the 1.15.0 milestone Sep 19, 2023
@tomhjp tomhjp requested a review from thyton September 19, 2023 18:55
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 19, 2023
@tomhjp tomhjp requested a review from kschoche September 19, 2023 18:55
Copy link
Contributor

@thyton thyton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@tomhjp tomhjp merged commit 873243d into main Sep 20, 2023
@tomhjp tomhjp deleted the vault-18186/fix-runtime-catalog-list-read branch September 20, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants