UI: HDS adoption replace <ListPagination> component #23169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
Monkeychip
commented
Sep 19, 2023
There was a problem hiding this comment.
affects several views, namespaces, auth method list (userpass names), kmip credentials, kmip scopes and kmip roles.
Monkeychip
commented
Sep 19, 2023
Monkeychip
commented
Sep 19, 2023
Monkeychip
commented
Sep 19, 2023
Monkeychip
commented
Sep 19, 2023
Monkeychip
commented
Sep 19, 2023
Monkeychip
commented
Sep 19, 2023
There was a problem hiding this comment.
Confirmed this still works as expected.
Monkeychip
changed the title
|
Build Results: |
kiannaquach
reviewed
Sep 19, 2023
| @@ -77,7 +77,6 @@ | |||
| @import './components/license-banners'; | |||
| @import './components/linked-block'; | |||
| @import './components/list-item-row'; | |||
| @import './components/list-pagination'; | |||
|
CI Results: |
hellobontempo
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
<Hds::Pagination>component. Additional notes below:Before:
After:
Additionally, this PR:
currentPageused in LDAP and KV v2 topageto be consistent with all the other use cases.Note: there is another pagination running around called "PaginationControls" —handling this in a separate pr.