Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: add SSH role attribute allowed_domains_template #23119

Merged
merged 4 commits into from
Sep 15, 2023
Merged

UI: add SSH role attribute allowed_domains_template #23119

merged 4 commits into from
Sep 15, 2023

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Sep 15, 2023 •
edited
Loading

This PR adds the allowed_domains_attribute to the UI interface for CA type SSH roles only.

Screenshot 2023-09-15 at 3 05 10 PM

@hashishaw hashishaw added this to the 1.13.8 milestone Sep 15, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 15, 2023
@hashishaw hashishaw force-pushed the ui/add-ssh-allowed-domains-template branch from fcfbcb1 to 73aeb5e Compare September 15, 2023 20:01
@hashishaw hashishaw changed the title UI: add ssh role attribute allowed_domains_template UI: add SSH role attribute allowed_domains_template Sep 15, 2023
hellobontempo
hellobontempo approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@hellobontempo hellobontempo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@hashishaw hashishaw enabled auto-merge (squash) September 15, 2023 20:23
@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@hashishaw hashishaw merged commit 3f9b607 into main Sep 15, 2023
@hashishaw hashishaw deleted the ui/add-ssh-allowed-domains-template branch September 15, 2023 21:35
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

This was referenced Sep 15, 2023
Merged
Merged
Merged
@Monkeychip Monkeychip mentioned this pull request Nov 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellobontempo hellobontempo hellobontempo approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.13.8
Development

Successfully merging this pull request may close these issues.
2 participants
@hashishaw @hellobontempo