UI: HDS adoption replace <CopyButton> part 5: Cleanup #22884

malinac02 · 2023-09-08T00:46:13Z

This is subtask 5 of 5 for the adoption of the <Hds::Copy::Button> and replacement of the <CopyButton>. This subtask is cleaning up the code. Specifically, this PR...

Removes the ember-cli-clipboard version 0.16.0 dependency no longer used, since we are now using version 1.0.0 which came in with the HDS upgrade in subtask 1 of 5
Removes classes no longer used
Cleans up the classes used for the copy button

…/VAULT-19017/replace-CopyButton-part-5

…re <CopyButton>

…cts with main, where the file is deleted

malinac02 · 2023-09-08T19:37:20Z

ui/app/components/sidebar/user-menu.hbs

@@ -44,7 +44,7 @@
                  @text="Copy token"
                  @textToCopy={{this.auth.currentToken}}
                  @isFullWidth={{true}}
-                  class="hds-copy-button size-7 hidden-icon link is-flex-start"
+                  class="hds-copy-button in-dropdown link is-flex-start"


Combined 2 classes into one, this is applied to copy buttons which are in dropdowns

malinac02 · 2023-09-08T19:38:32Z

ui/lib/kmip/addon/templates/credentials/show.hbs

@@ -34,7 +34,7 @@
    <Hds::Copy::Button
      @text="Copy certificate"
      @textToCopy={{this.model.certificate}}
-      class="toolbar-link is-flex-center hds-copy-button"
+      class="toolbar-link is-flex-center"


toolbar-link class already covers necessary styling, so removed extra class here

malinac02 · 2023-09-08T19:39:50Z

ui/package.json

@@ -125,7 +125,6 @@
    "ember-cli": "~4.12.1",
    "ember-cli-autoprefixer": "^0.8.1",
    "ember-cli-babel": "^7.26.11",
-    "ember-cli-clipboard": "0.16.0",


Removed ember-cli-clipboard 0.16.0 because we no longer have structure copy button which relied on this. HDS copy button is dependent on ember-cli-clipboard 1.0.0, which was added when I upgraded HDS to 2.9.0 in first subtask of copy button replacement

github-actions · 2023-09-08T19:56:15Z

Build Results:
All builds succeeded! ✅

kiannaquach · 2023-09-08T20:11:59Z

ui/app/styles/core/buttons.scss

+    }
+  }
+
+  &.in-dropdown {


nice job combining the classes!

hellobontempo · 2023-09-12T16:38:33Z

ui/lib/kmip/addon/templates/credentials/show.hbs

-        @name="Private key"
-        @allowCopy={{true}}
-        @displayOnly={{true}}
-        class="is-block"


Remove is-block class

before:

after

hellobontempo · 2023-09-12T16:39:27Z

ui/lib/kmip/addon/templates/credentials/show.hbs

-      />
-    </div>
-  </InfoTableRow>
+  {{#if this.model.privateKey}}


🧹 added this conditional as small cleanup - this row was rendering when there was no private key data

…/VAULT-19017/replace-CopyButton-part-5

* Part 1: Upgrade HDS to 2.9.0 (#22311) * UI: HDS adoption replace <CopyButton> part 2 (#22356) * certificate-card.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * scope-form.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * fix tests caused by changing certificate-card. change hds copy button in certificate-card.hbs * json-editor.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * masked-input.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * fix error with certificate-card.hbs copy button * fix tests that deal with certificate-card.hbs * add class to hds copy buttons to maintain similar styling to curent UI * info-table-row.hbs: replace 2 <CopyButton> with <Hds::Copy::Button> * undo change that should instead by merged in from main * change tooltip copy button to white. cleanup * add extra tet for oidc scope form. edit css class for the white icon copy button * fix tests * UI: HDS adoption replace <CopyButton> part 3 (#22614) * encrypt.hbs: replace 2 <CopyButton> with <Hds::Copy::Button> * decrypt.hbs: replace 2 <CopyButton> with <Hds::Copy::Button> * datakey.hbs. replace 6 <CopyButton> with <Hds::Copy::Button> * rewrap.hbs: replace 2 <CopyButton> with <Hds::Copy::Button> * hmac.hbs: replace 2 <CopyButton> with <Hds::Copy::Button> * fix typo * add copy-close class to copy & close buttons * export.hbs: replace 2 <CopyButton> with <Hds::Copy::Button>. fix styling * sign.hbs: replace 2 <CopyButton> with <Hds::Copy::Button> * fix test caused by changing <pre> tag to <code> in export.hbs * rename class * add extra style to class needed for part 4 of copy button replacement * UI: HDS adoption replace <CopyButton> part 4 (#22749) * user-menu.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * transit-form-show.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * configure-ssh-secret.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * tool-hash.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * tool-random.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * tool-rewrap.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * tool-unwrap.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * tool-wrap.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * paths.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * code-snippet.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * cleanup css for code-snippet. add comments for getting rid of code-snippet and replacing with <Hds::Copy::Snippet * change code-snippet copy icon to gray to match original design * change code-snippet class * accounts.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * hover-copy-button.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * add.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * show.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * copy-secret-dropdown.hbs: replace 1 <CopyButton> with <Hds::Copy::Button> * change styling of 'link' copy buttons * generate-credentials.hbs: replace 2 <CopyButton> with <Hds::Copy::Button> * transform-show-transformation.hbs: replace 2 <CopyButton> with <Hds::Copy::Button> * sign.hbs: replace 2 <CopyButton> with <Hds::Copy::Button> * hide some copy buttons' icons and use original flash message * undo cleanup of scss file so that I can put cleanup all into one PR to be more organized * update code snippet copy button * UI: HDS adoption replace <CopyButton> part 5: Cleanup (#22884) * remove unecessary code-snippet.scssn class * remove copy classes from masked-input.scss * remove copy button class from text-file.scss * uninstall ember-cli-clipboard 0.16.0 since there is no longer structure <CopyButton> * remove copyright message from code-snippet.scss to avoid merge conflicts with main, where the file is deleted * replace 2 classes with one * remove unecessary class from copy button * cleanup classes * revert changes to avoid merge conflicts * remove is-block class * conditionally render private key * add more info to comment * remove HoverCopyButton * add missing selector * fix control group padding --------- Co-authored-by: [email protected] <[email protected]> Co-authored-by: claire bontempo <[email protected]> * rename class to transparent background * remove unused test selectors * replace transit actions with Copy::Snippet * replace transfrom code blocks with code snippet component * revert extra css fiddling * misc cleanup, unused action * remove copy & close buttons from transit modals * remove is- from class naming * remove hds-copy-button class * add other grey class * more small cleanup * add -top to margin * add changelog --------- Co-authored-by: [email protected] <[email protected]> Co-authored-by: claire bontempo <[email protected]>

malinac02 added 3 commits September 7, 2023 17:34

remove unecessary code-snippet.scssn class

9093b2b

remove copy classes from masked-input.scss

30a6f7d

remove copy button class from text-file.scss

1881983

malinac02 added ui pr/no-changelog hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Sep 8, 2023

malinac02 added this to the 1.16 milestone Sep 8, 2023

malinac02 and others added 5 commits September 8, 2023 09:41

Merge branch 'ui/VAULT-18829/hds-adoption-replace-CopyButton' into ui…

dba8f5e

…/VAULT-19017/replace-CopyButton-part-5

uninstall ember-cli-clipboard 0.16.0 since there is no longer structu…

576ebc6

…re <CopyButton>

remove copyright message from code-snippet.scss to avoid merge confli…

07893ff

…cts with main, where the file is deleted

replace 2 classes with one

10d9896

remove unecessary class from copy button

ba39e73

malinac02 commented Sep 8, 2023

View reviewed changes

malinac02 marked this pull request as ready for review September 8, 2023 19:43

kiannaquach reviewed Sep 8, 2023

View reviewed changes

ui/app/styles/core/buttons.scss

}

}

&.in-dropdown {

Copy link

Contributor

kiannaquach Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job combining the classes!

malinac02 reacted with laugh emoji

malinac02 and others added 4 commits September 8, 2023 15:33

cleanup classes

fd73aa9

revert changes to avoid merge conflicts

4563973

remove is-block class

5c776ab

conditionally render private key

af592ad

hellobontempo reviewed Sep 12, 2023

View reviewed changes

hellobontempo and others added 5 commits September 12, 2023 10:05

add more info to comment

75b8a20

remove HoverCopyButton

dec1736

add missing selector

4abd1b7

fix control group padding

9386f90

Merge branch 'ui/VAULT-18829/hds-adoption-replace-CopyButton' into ui…

d37d5d0

…/VAULT-19017/replace-CopyButton-part-5

hellobontempo merged commit a27881c into ui/VAULT-18829/hds-adoption-replace-CopyButton Sep 13, 2023
10 checks passed

hellobontempo deleted the ui/VAULT-19017/replace-CopyButton-part-5 branch September 13, 2023 23:37

vercel bot deployed to Preview September 13, 2023 23:42 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI: HDS adoption replace <CopyButton> part 5: Cleanup #22884

UI: HDS adoption replace <CopyButton> part 5: Cleanup #22884

malinac02 commented Sep 8, 2023 •

edited

Loading

malinac02 Sep 8, 2023

malinac02 Sep 8, 2023

malinac02 Sep 8, 2023

github-actions bot commented Sep 8, 2023

kiannaquach Sep 8, 2023

hellobontempo Sep 12, 2023

hellobontempo Sep 12, 2023

UI: HDS adoption replace <CopyButton> part 5: Cleanup #22884

UI: HDS adoption replace <CopyButton> part 5: Cleanup #22884

Conversation

malinac02 commented Sep 8, 2023 • edited Loading

malinac02 Sep 8, 2023

Choose a reason for hiding this comment

malinac02 Sep 8, 2023

Choose a reason for hiding this comment

malinac02 Sep 8, 2023

Choose a reason for hiding this comment

github-actions bot commented Sep 8, 2023

kiannaquach Sep 8, 2023

Choose a reason for hiding this comment

hellobontempo Sep 12, 2023

Choose a reason for hiding this comment

before:

after

hellobontempo Sep 12, 2023

Choose a reason for hiding this comment

malinac02 commented Sep 8, 2023 •

edited

Loading