Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: [VAULT-19478] Fix info table row value overflow #22776

Merged
merged 4 commits into from
Sep 5, 2023
Merged

UI: [VAULT-19478] Fix info table row value overflow #22776

merged 4 commits into from
Sep 5, 2023

Conversation

kiannaquach
Copy link
Contributor

@kiannaquach kiannaquach commented Sep 5, 2023 •
edited
Loading

Before
Screenshot 2023-09-05 at 1 04 34 PM

After truncating long path names:
Screenshot 2023-09-05 at 2 08 31 PM

@kiannaquach kiannaquach added this to the 1.15 milestone Sep 5, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 5, 2023
@kiannaquach kiannaquach marked this pull request as ready for review September 5, 2023 21:10
kiannaquach
kiannaquach commented Sep 5, 2023
View reviewed changes
Copy link
Contributor Author

@kiannaquach kiannaquach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole kv paths page isn't responsive, so long paths get cut off. A nice to have is to make the whole page including the header and info-table-row fully responsive.

Monkeychip
Monkeychip approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for tackling! I checked out the branch and did some testing and all looked good.

@kiannaquach kiannaquach changed the title UI: Fix info table row value overflow UI: [VAULT-19478] Fix info table row value overflow Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Build Results:
All builds succeeded! ✅

@kiannaquach kiannaquach merged commit 00331b7 into main Sep 5, 2023
@kiannaquach kiannaquach deleted the ui/kv-path-truncate branch September 5, 2023 21:52
kiannaquach added a commit that referenced this pull request Sep 5, 2023
@kiannaquach
UI: [VAULT-19478] Fix info table row value overflow (#22776)
786d419
@kiannaquach kiannaquach mentioned this pull request Sep 5, 2023
Merged
@malinac02 malinac02 mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Milestone
1.15.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@kiannaquach @Monkeychip