Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential panic in audit during header formatting #22694

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

peteski22
Copy link

This PR updates the way in which the HeaderFormatter option is applied such that it will not allow interfaces with nil type or value to be set.

The aim of the PR is to prevent the ability for audit code to panic in certain circumstances when the formatter appears to be !=nil but ends up as a nil pointer receiver.

@peteski22 peteski22 added bug Used to indicate a potential bug core/audit do-not-merge hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Aug 31, 2023
@peteski22 peteski22 added this to the 1.15 milestone Aug 31, 2023
@peteski22 peteski22 requested a review from ncabatoff August 31, 2023 17:06
@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@ncabatoff ncabatoff marked this pull request as ready for review August 31, 2023 17:28
@ncabatoff ncabatoff enabled auto-merge (squash) August 31, 2023 17:28
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@ncabatoff ncabatoff merged commit d2d3d8a into main Aug 31, 2023
@ncabatoff ncabatoff deleted the peteski22/fix/audit-panic-headerformatter branch August 31, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug core/audit do-not-merge hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants