Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: kv-v2 version history & path tests #22593

Merged
merged 17 commits into from
Aug 30, 2023

Conversation

hashishaw
Copy link
Contributor

Workflow test coverage for version history page and paths page in the KV V2 engine.

As part of this work, 2 enhancements were made:

Move diff view to Create New Version form
Removed the dedicated diff page view, and we can move it back if we get requests for it.
Diff view expanded on new secret version

Enabled metadata read via control groups
Fixed a workflow where user has a control group on metadata read access.

@hashishaw hashishaw added the ui label Aug 28, 2023
@hashishaw hashishaw added this to the 1.15 milestone Aug 28, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 28, 2023
@github-actions
Copy link

github-actions bot commented Aug 28, 2023

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool to see this added!

@hashishaw hashishaw merged commit b18313b into main Aug 30, 2023
@hashishaw hashishaw deleted the ui/VAULT-18817/kv-version-history-path-tests branch August 30, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants