Add the ability to set seconds in cron schedule for testing purposes #22531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* handle mutual exclusion of rotation fields * fix import
* adv ttl mgmt: add rotation_window field * do some rotation_window validation and add unit tests
#22341) * general cleanup and refactor rotation type checks * make NextRotationTime account for the rotation type * add comments
* add unit tests to handle mutual exclusion * revert rotation_test.go and add missing test case to path_roles_test.go
* support manual rotation for schedule based roles * update description and naming
* consider rotation window ensure rotations only occur within a rotation window for schedule-based rotations * use helper method to set priority in rotateCredential * fix bug with priority check * remove test for now * add and remove comments
* update read static-creds endpoint to include correct resp data * return rotation_window if set * update
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
vinay-gopalan
approved these changes
Aug 23, 2023
raymonstah
reviewed
Aug 23, 2023
….com/hashicorp/vault into VAULT-19131/toggle-seconds
|
Ugh, I had some issues with merging main into this PR since we merged the feature branch. I tried rebasing first, but I was having issues with go.mod and go.sum, not sure why. |
raymonstah
approved these changes
Aug 25, 2023
fairclothjm
reviewed
Aug 25, 2023
fairclothjm
reviewed
Aug 25, 2023
fairclothjm
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.