Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: [VAULT-19160 VAULT-19159] Dashboard card order, minor cleanup tasks, and update page header #22413

Merged

Conversation

kiannaquach
Copy link
Contributor

@kiannaquach kiannaquach commented Aug 17, 2023

Description

  • updated the original .is-flex-1 class to .is-flex-grow-1 and updated all the files that use is-flex-1 to is-flex-grow-1.
// ORIGINAL CLASS
.is-flex-1 {
  flex-grow: 1;
  &.basis-0 {
    flex-basis: 0;
  }
}

// UPDATED CLASS
.is-flex-grow-1 {
  flex-grow: 1;
  &.basis-0 {
    flex-basis: 0;
  }
}
  • the class I added was called is-flex-1 since that class only contained the flex: 1 property. is-flex-1 makes more sense here. Please let me know if I should do this in a separate PR or keep the original class the way it was and rename my class to something else.
// CLASS ADDED/UPDATED
.is-flex-1 {
	flex: 1;
}
  • Move the HDS::Card::Container into the respective components (secrets-engines-card, quick-actions-card, vault-configuration-card, client-count-card, replication-card, and learn-more-card) rather than having it live in the dashboard route template
  • Updated kv quick actions form label to be title-cased rather than capitalized
  • Added a secrets-engines-card.scss file to add a height for the secrets engines card.
Screenshot 2023-08-17 at 3 54 12 PM
  • Updated the ordering of the cards on Enterprise:
Screenshot 2023-08-17 at 3 41 19 PM
  • Updated the ordering on OSS:
Screenshot 2023-08-17 at 3 40 26 PM
  • VAULT-19159 Use PageHeader component so the margin matches other pages
    Before:
Screenshot 2023-08-17 at 3 20 10 PM After: Screenshot 2023-08-17 at 3 39 29 PM

@kiannaquach kiannaquach added this to the 1.15 milestone Aug 17, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 17, 2023
@kiannaquach kiannaquach marked this pull request as ready for review August 17, 2023 22:21
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@kiannaquach kiannaquach changed the title UI: [VAULT-19160] Dashboard card order UI: [VAULT-19160 VAULT-19159] Dashboard card order, minor cleanup tasks, and update page header Aug 17, 2023
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of non-blocking comments. Thanks!

@kiannaquach kiannaquach merged commit 60bd75b into ui/landing-page-dashboard Aug 18, 2023
@kiannaquach kiannaquach deleted the ui/VAULT-19160/dashboard-card-reordering branch August 18, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants