-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: [VAULT-19160 VAULT-19159] Dashboard card order, minor cleanup tasks, and update page header #22413
Merged
kiannaquach
merged 12 commits into
ui/landing-page-dashboard
from
ui/VAULT-19160/dashboard-card-reordering
Aug 18, 2023
Merged
UI: [VAULT-19160 VAULT-19159] Dashboard card order, minor cleanup tasks, and update page header #22413
kiannaquach
merged 12 commits into
ui/landing-page-dashboard
from
ui/VAULT-19160/dashboard-card-reordering
Aug 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Aug 17, 2023
…e is just updating flex-grow: 1
…the respective cards
Build Results: |
kiannaquach
changed the title
UI: [VAULT-19160] Dashboard card order
UI: [VAULT-19160 VAULT-19159] Dashboard card order, minor cleanup tasks, and update page header
Aug 17, 2023
Monkeychip
reviewed
Aug 18, 2023
Monkeychip
reviewed
Aug 18, 2023
Monkeychip
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of non-blocking comments. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.is-flex-1
class to.is-flex-grow-1
and updated all the files that useis-flex-1
tois-flex-grow-1
.is-flex-1
since that class only contained theflex: 1
property.is-flex-1
makes more sense here. Please let me know if I should do this in a separate PR or keep the original class the way it was and rename my class to something else.HDS::Card::Container
into the respective components (secrets-engines-card
,quick-actions-card
,vault-configuration-card
,client-count-card
,replication-card
, andlearn-more-card
) rather than having it live in the dashboard route templatesecrets-engines-card.scss
file to add a height for the secrets engines card.Before: