Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: [VAULT-17044] Replication card #22354

Merged

Conversation

kiannaquach
Copy link
Contributor

@kiannaquach kiannaquach commented Aug 15, 2023

Description
When both performance and dr replication is returned from the version features array:
dr-perf-only

When performance isn't returned from the version features array and it is DR replication only:
dr-only

TODO's:

  • Reordering of all the cards in separate PR
  • Acceptance tests for replication card in separate PR
  • Integration test for Dashboard::ReplicationStateText

@kiannaquach kiannaquach added this to the 1.15 milestone Aug 15, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 15, 2023
@kiannaquach kiannaquach marked this pull request as ready for review August 16, 2023 19:27
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! A couple minor comments

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment suggesting how to refactor and make a more modular component - let me know if you have questions or want to pair! ⭐

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This is much easier to parse! 🎉

version: this.version,
license: this.getLicense(),
});
}

@action
refreshRoute() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the entire model hook will refresh when this method is called?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct! The replication query is attached to the top-level cluster route model. We customize the findRecord in the cluster adapter

ui/app/templates/components/dashboard/replication-card.hbs Outdated Show resolved Hide resolved
ui/app/templates/components/dashboard/replication-card.hbs Outdated Show resolved Hide resolved
@kiannaquach kiannaquach merged commit 0c0e1aa into ui/landing-page-dashboard Aug 17, 2023
@kiannaquach kiannaquach deleted the ui/VAULT-17044/replication-card-dashboard branch August 17, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants