-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: [VAULT-17044] Replication card #22354
UI: [VAULT-17044] Replication card #22354
Conversation
Build Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! A couple minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment suggesting how to refactor and make a more modular component - let me know if you have questions or want to pair! ⭐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This is much easier to parse! 🎉
version: this.version, | ||
license: this.getLicense(), | ||
}); | ||
} | ||
|
||
@action | ||
refreshRoute() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the entire model hook will refresh when this method is called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct! The replication query is attached to the top-level cluster
route model. We customize the findRecord in the cluster adapter
Description
When both performance and dr replication is returned from the version features array:
When performance isn't returned from the version features array and it is DR replication only:
TODO's:
Dashboard::ReplicationStateText