UI: [VAULT-17041] Client count card #22323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
kiannaquach
changed the title
|
Build Results: |
Monkeychip
reviewed
Aug 15, 2023
| @@ -50,6 +50,7 @@ | |||
| @route={{backend.backendLink}} | |||
| @model={{backend.id}} | |||
| class="has-text-weight-semibold is-no-underline" | |||
| target="_blank" | |||
There was a problem hiding this comment.
Just confirming that we indeed want these links to always open in a new tab? My understanding is you only do that if you're linking off your website. Ex: we were linking to documentation.
There was a problem hiding this comment.
I'll reconfirm with design and get back to you! The reason why we added this is that the breadcrumbs don't match the behavior of the link. Going to remove the new tab links for now.
Monkeychip
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO's in different PR: