Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the omitempty json flags within CIEPSResponse #22305

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Adjust the omitempty json flags within CIEPSResponse #22305

merged 1 commit into from
Aug 11, 2023

Conversation

stevendpclark
Copy link
Contributor

  • Remove the omitempty flag from issuer_ref, and add it to the warnings and error fields

@stevendpclark
Adjust the omitempty json flags within CIEPSResponse
0d58811 
 - Remove the omitempty flag from issuer_ref, and add it to the
   warnings and error fields
@stevendpclark stevendpclark self-assigned this Aug 11, 2023
@stevendpclark stevendpclark requested a review from a team August 11, 2023 20:00
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 11, 2023
cipherboy
cipherboy approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Errors and warnings are optional, we want to explicitly state that certificate is empty (in the event of an error), and issuer_ref is a mandatory field.

@stevendpclark stevendpclark enabled auto-merge (squash) August 11, 2023 20:12
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@stevendpclark stevendpclark merged commit 510cce5 into main Aug 11, 2023
@stevendpclark stevendpclark deleted the stevendpclark/cieps-omit-empty branch August 11, 2023 20:17
@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

hellobontempo pushed a commit that referenced this pull request Aug 18, 2023
@stevendpclark @hellobontempo
Adjust the omitempty json flags within CIEPSResponse (#22305)
65eddbd 
- Remove the omitempty flag from issuer_ref, and add it to the
   warnings and error fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipherboy cipherboy cipherboy approved these changes

@kitography kitography Awaiting requested review from kitography

Assignees

@stevendpclark stevendpclark

Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone secret/pki
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevendpclark @cipherboy