-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a distinguishing prefix to OpenAPI operation IDs for enterprise stubs #22072
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
vault/logical_system_helpers.go
Outdated
// OpenAPI won't be good for much other than identifying the endpoint exists at all. Thus, it | ||
// is useful to make it clear that this is only a stub. Code generation will use this to ignore | ||
// these operations. | ||
OperationPrefix: "enterprise-stub-system", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick thought. Would it make sense to call this "enterprise-stub" instead? For other prefixes under /sys
, we've been dropping the "system" part. It's not a big deal regardless since it will be filtered out, just a thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The system-
prefix had not been dropped for any of these, so I was just prepending enterprise-stub-
to what was already there. But, sure, might as well bring these into line with the surrounding convention as well.
In that case, I'll also fix sys/replication/status
which is not a stub, but hasn't had the system
part dropped yet.
As discussed in hashicorp/vault-client-go#208