Backport of VAULT-17590 Enterprise-side changes (using CI Vault over GH Secret) into release/1.13.x #21997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hc-github-team-secure-vault-core
force-pushed
the
backport/violethynes/VAULT-17590-ent-changes/rightly-brief-mouse
branch
2 times, most recently
from
15fc72c to
6392634
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
* VAULT-17590 Add failure notifications for OSS builds * VAULT-17590 Incur build failure for testing purposes * VAULT-17590 head_ref for testing * VAULT-17590 rework to rely on completed status checks * VAULT-17590 Use slackapi/slack-github-action * VAULT-17590 Remember dollar sign * VAULT-17590 finalize PR * VAULT-17590 add extra empty line * Update .github/workflows/build.yml Co-authored-by: Kuba Wieczorek <[email protected]> * Update .github/workflows/ci.yml Co-authored-by: Kuba Wieczorek <[email protected]> * VAULT-17590 fix typo * VAULT-17590 ent workflow * VAULT-17590 typo --------- Co-authored-by: Kuba Wieczorek <[email protected]>
miagilepner
force-pushed
the
backport/violethynes/VAULT-17590-ent-changes/rightly-brief-mouse
branch
from
3fcb8ab to
dd22fea
Compare
VioletHynes
approved these changes
Jul 21, 2023
VioletHynes
deleted the
backport/violethynes/VAULT-17590-ent-changes/rightly-brief-mouse
branch
|
CI Results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21587 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
🚨
The person who merged in the original PR is:
@VioletHynes
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
I thought this approach, of making two jobs, one running on OSS, one on Ent, was probably best, since we can keep both in the OSS repo and avoid merge conflicts if we need to change them.
Sorry about the commit history, I accidentally included the commits from the old PR. Should be good, though, and naturally, will be squashed.
Overview of commits