Backport of Remove caseSensitivityKey invalidation into release/1.12.x #21877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/vault-16845-oss/happily-deep-feline
branch
2 times, most recently
from
5daab21 to
525f76e
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
akshya96
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20965 to be assessed for backporting due to the inclusion of the label backport/1.12.x.
The below text is copied from the body of the original PR.
Jira issue: https://hashicorp.atlassian.net/browse/VAULT-16845
Ent PR: https://github.com/hashicorp/vault-enterprise/pull/4233
A problem occurs when the caseSensitivityKey is invalidated due to a change in its value from True to False in storage, and duplicate groups are discovered. As a result, the loadGroups function returns an error, preventing the loading of groups and potentially causing missing groups in the memDB.
To resolve this issue, the proposed solution is to eliminate the invalidation case for the caseSensitivityKey. Since the value in storage can only be changed on the primary active node during initialization, there is no need for further invalidation. A warning is anyways being logged in loadIdentityStoreArtifacts function during the unseal process before initialization, if duplicate groups are encountered.
Overview of commits