Fix ACME tidy to not reference acmeContext #21870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
acmeContext is useful for when we need to reference things with a ACME base URL, but everything used in tidy doesn't need this URL as it is not coming from an ACME request. Refactor tidy to remove references to acmeContext, including dependent functions in acme_state.go. Signed-off-by: Alexander Scheel <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
Co-authored-by: kitography <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
Co-authored-by: kitography <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
Co-authored-by: kitography <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
Co-authored-by: kitography <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
Resolve: #21872 Co-authored-by: kitography <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
Co-authored-by: kitography <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
force-pushed
the
cipherboy-fix-acme-tidy
branch
from
9c1ab4b to
adeb296
Compare
This was referenced Jul 17, 2023
Signed-off-by: Alexander Scheel <[email protected]>
kitography
reviewed
Jul 17, 2023
stevendpclark
approved these changes
Jul 17, 2023
cipherboy
commented
Jul 17, 2023
kitography
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acmeContextis useful for when we need to reference things with a ACME base URL, but everything used in tidy doesn't need this URL as it is not coming from an ACME request.Refactor tidy to remove references to
acmeContext, including dependent functions inacme_state.go.Resolves: #21866
Resolves: #21872