Backport of UI: Remove logic that skips sending object if not changed into release/1.14.x #21759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-17902/ssh-role-removing-objects-on-edit/carefully-immense-grackle
branch
from
29a11fb to
08c4ac0
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-17902/ssh-role-removing-objects-on-edit/carefully-immense-grackle
branch
from
bec4166 to
feade62
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
…emoving-objects-on-edit/carefully-immense-grackle
hashishaw
approved these changes
Jul 20, 2023
|
Build Results: |
hashishaw
deleted the
backport/ui/VAULT-17902/ssh-role-removing-objects-on-edit/carefully-immense-grackle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21739 to be assessed for backporting due to the inclusion of the label backport/1.14.x.
The below text is copied from the body of the original PR.
This PR fixes an issue on the UI where editing an SSH role with
default_extensionset causes thedefault_extensionto be cleared on edit (#21571)I spot-checked all the other places where we use
attr('object')and they seem to work (create, update) fine. Usually on update forms we usePOSTwith the entire payload, so I'm not sure why this was the default behavior but if we find instances that this needs to be the case we can override those specific serializers.Overview of commits