Add permet pool metrics to dynamo db backend #21742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -122,6 +123,12 @@ type DynamoDBLockRecord struct { | |||
| Expires int64 | |||
| } | |||
|
|
|||
| type PermitPoolWithMetrics struct { | |||
| physical.PermitPool | |||
| pendingPermits int32 | |||
There was a problem hiding this comment.
minor: run git fmt. It should align these types with spaces
thomashargrove
approved these changes
Jul 11, 2023
|
Hey! Thanks for adding this. It looks great to me. I added a changelog, and I'm going to try and get this one merged. Appreciate the contribution! |
VioletHynes
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #21588
To aid in debugging we want to have metrics on the number of requests in the permit pool for the dynamodb backend and the number of waiting requests. This change implements this by adding NewPermitPoolWithMetrics which shadows the existing permit pool definition except with calls to publish metrics on the pool size, active requests. and waiting requests before and after each permit is acquired or released
Example metrics from Vault:
