pre-commit hook for formatting backend code #21682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
Closed
By taking a slight penalty with each commit, we can ensure that contributors follow the format behavior by default (if they run hooks), making accidental PRs without proper formatting less likely. Additionally, fix gofmtcheck to align with the Makefile, fixing the corresponding fmtcheck target for use with the hook. Signed-off-by: Alexander Scheel <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
force-pushed
the
cipherboy-pre-commit-hook-for-formatting
branch
from
6f42a4a to
a18206a
Compare
stevendpclark
approved these changes
Jul 10, 2023
averche
approved these changes
Jul 10, 2023
This was referenced Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds/updates the pre-commit hook to add a backend format checking prior to commit, similar to the existing UI check.
This should reduce the number of PR authors (mostly, myself) who commit things without checking that
fmtCI has passed... :-)