Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't say "Success!" when a specific field is requested. #21546

Merged
merged 5 commits into from
Aug 17, 2023
Merged

Don't say "Success!" when a specific field is requested. #21546

merged 5 commits into from
Aug 17, 2023

Conversation

maokt
Copy link
Contributor

@maokt maokt commented Jul 2, 2023

vault write should not output the "Success!" message when a specific field is requested; it should output nothing if the response is empty.
Fixes #21545.

@maokt maokt requested a review from a team as a code owner July 2, 2023 15:58
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 2, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mpalmi mpalmi added the command label Jul 3, 2023
@schavis
Copy link
Contributor

schavis commented Jul 6, 2023

The content change LGTM. Please have someone familiar with the testing code review those changes before merging.

@maokt maokt force-pushed the fix-write-results branch 3 times, most recently from fd4a860 to d23a5d6 Compare July 9, 2023 17:40
@maokt maokt force-pushed the fix-write-results branch from d23a5d6 to e4ee065 Compare July 21, 2023 16:33
@yhyakuna yhyakuna requested a review from a team July 25, 2023 15:29
@maokt maokt force-pushed the fix-write-results branch from e4ee065 to 93c295e Compare July 30, 2023 05:41
@schavis
Copy link
Contributor

schavis commented Aug 10, 2023

Docs updates LGTM. Feel free to merge once the code changes are approved as well.

@schavis schavis requested review from schavis and removed request for a team August 10, 2023 16:31
@maokt maokt force-pushed the fix-write-results branch from 93c295e to 219b2f9 Compare August 12, 2023 23:27
@maokt maokt force-pushed the fix-write-results branch from 219b2f9 to 5ecb9ff Compare August 16, 2023 00:03
VioletHynes
VioletHynes approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@VioletHynes VioletHynes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for this submission, and we really appreciate the addition of the test. Going to try and get this merged.

@VioletHynes VioletHynes merged commit 6ceee62 into hashicorp:main Aug 17, 2023
rebwill pushed a commit that referenced this pull request Aug 18, 2023
@maokt @VioletHynes @rebwill
Don't say "Success!" when a specific field is requested. (#21546)
37b96d0 
* add a test to show the bug

* do not output a "Success!" message if a specific field was requested

* Create 21545.txt

* Fix changelog name

---------

Co-authored-by: Violet Hynes <[email protected]>
@maokt maokt deleted the fix-write-results branch August 18, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VioletHynes VioletHynes VioletHynes approved these changes

@schavis schavis Awaiting requested review from schavis

Assignees
No one assigned
Labels
command
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't say "Success!" when a specific field is requested.
5 participants
@maokt @hashicorp-cla @schavis @VioletHynes @mpalmi