Fix incorrect OpenAPI operation ID #21543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The operation ID for `GET auth/token/lookup` has been overridden in a way which *implies* it can only perform lookup-self operations. This is not true, as shown: 1) Here is my current token: ``` $ vault read -field=display_name auth/token/lookup userpass-admin ``` 2) I create a second token, with a different display name to distinguish it: ``` $ othertoken=$(vault token create -field=token -display-name=testing123) ``` 3) I use this operation, still authenticated with the first token, to lookup the second token, proving it does not have lookup-self nature: ``` $ vault read -field=display_name auth/token/lookup token=$othertoken token-testing123 ``` I have set the new operation ID suffix to `"2"` adhering to current conventions in `vault-client-go` and `vault-client-dotnet` for secondary versions of APIs which should be excluded from the generated library code.
averche
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operation ID for
GET auth/token/lookuphas been overridden ina way which implies it can only perform lookup-self operations.
This isn't actually the case, as shown:
it:
lookup the second token, showing it is not actually a lookup-self operation:
I have set the new operation ID suffix to
"2"adhering to currentconventions in
vault-client-goandvault-client-dotnetfor secondaryversions of APIs which should be excluded from the generated library
code.
I have confirmed this doesn't give rise to any new clashes between operation IDs.