Backport of Fix vault path-help
for selected paths with bad regexps into release/1.13.x
#21528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18571 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
🚨
The person who merged in the original PR is:
@hghaf099
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Describe the bug
When a Vault API path has been defined with a regex that requires a final slash, the
vault path-help
command is unable to retrieve help for it.Underlying cause
Vault's code automatically appends a trailing slash on to all paths used for
ListOperation
s, but removes a trailing slash for all other operations, includingHelpOperation
s. In order for a path pattern to match bothListOperation
andHelpOperation
, it must accept both the presence and absence of a trailing slash.To Reproduce, or test the fix
vault path-help auth/token/accessors/
unsupported path
errorExpected behavior
Help message displayed as expected.
Fix
Update the few path regex patterns that fall into this trap to end with
/?
instead of/
.Update a comment to explain why.
Overview of commits