UI: HDS adoption replace <ConfirmAction> component #21520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VioletHynes
added
the
hashicorp-contributed-pr
hellobontempo
commented
Nov 16, 2023
hellobontempo
commented
Nov 16, 2023
| @@ -48,6 +48,18 @@ | |||
| width: 100%; | |||
| } | |||
|
|
|||
| // TODO HDS polish - temp styling fix for ConfirmAction dropdown buttons | |||
There was a problem hiding this comment.
How the popup menu styling looks - left is new component with this class, right is old component
hellobontempo
commented
Nov 16, 2023
hellobontempo
commented
Nov 16, 2023
| @@ -21,14 +21,11 @@ | |||
|
|
|||
| <div class="field is-grouped box is-fullwidth is-bottomless"> | |||
| <ConfirmAction | |||
| @buttonClasses="button is-primary" | |||
hellobontempo
commented
Nov 16, 2023
| @@ -8,13 +8,14 @@ | |||
| <ul class="menu-list"> | |||
| <li class="action"> | |||
| <ConfirmAction | |||
| @buttonClasses="link is-destroy" | |||
hellobontempo
commented
Nov 16, 2023
| @@ -8,14 +8,13 @@ | |||
| <ul class="menu-list"> | |||
| <li class="action"> | |||
| <ConfirmAction | |||
| @buttonText="Remove" | |||
|
Build Results: |
hashishaw
approved these changes
Nov 16, 2023
hellobontempo
commented
Nov 16, 2023
hellobontempo
deleted the
ui/VAULT-17329/replace-confirm-action-dropdown-with-modal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
<ConfirmAction>dropdown with a Button + confirmation modal. In addition, I updated the logic to be more general, instead of explicitly referencingDeleteactions, which better aligns with how this component is usedSummary of changes:
@confirmTextarg and instead modal buttons are alwaysConfirmandCancelfor consistencyAre you sure?which is more general than the previousDelete this?confirm/messagenew | previous functionality