Fix OpenAPI spec definitions for PKI EAB APIs #21458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevendpclark
commented
Jun 26, 2023
stevendpclark
commented
- Do not generate duplicate operation ids for the various new-eab apis
- Fill out proper operation verb for eab delete call
- Pluralize operation verb for list-eab-keys api
- Fill out proper response data for new-eab and list-eab-keys
- Do not generate duplicate operation ids for the various new-eab apis - Fill out proper operation verb for eab delete call - Pluralize operation verb for list-eab-keys api - Fill out proper response data for new-eab and list-eab-keys
averche
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Thanks for fixing this!
For future reference, these are the new EAB OpenAPI OperationIDs:
| Path | Method | OperationID |
|---|---|---|
| /{pki_mount_path}/eab | get | pki-list-eab-keys |
| /{pki_mount_path}/eab/{key_id} | delete | pki-delete-eab-key |
| /{pki_mount_path}/acme/new-eab | post | pki-generate-eab-key |
| /{pki_mount_path}/issuer/{issuer_ref}/acme/new-eab | post | pki-generate-eab-key-for-issuer |
| /{pki_mount_path}/issuer/{issuer_ref}/roles/{role}/acme/new-eab | post | pki-generate-eab-key-for-issuer-and-role |
| /{pki_mount_path}/roles/{role}/acme/new-eab | post | pki-generate-eab-key-for-role |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.