Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix tidy with maintain_stored_certificate_counts == publish_stored_certificate_count_metrics == false into release/1.12.x #21413

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #20664 to be assessed for backporting due to the inclusion of the label backport/1.12.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@cipherboy
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


The logic around the check to set both to false was wrong, and should be validated independently.

Additionally, these fields should only exist on auto-tidy and not on the manual tidy endpoint.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/cipherboy-fix-bug-setting-both-fields-false/vigorously-witty-mongoose branch 2 times, most recently from 54536f0 to 249a54c Compare June 22, 2023 16:43
@hashicorp-cla
Copy link

hashicorp-cla commented Jun 22, 2023

CLA assistant check
All committers have signed the CLA.

@cipherboy cipherboy force-pushed the backport/cipherboy-fix-bug-setting-both-fields-false/vigorously-witty-mongoose branch from c895459 to 1c07fbf Compare June 22, 2023 16:58
Signed-off-by: Alexander Scheel <[email protected]>
@cipherboy cipherboy force-pushed the backport/cipherboy-fix-bug-setting-both-fields-false/vigorously-witty-mongoose branch from 1c07fbf to cc8bef0 Compare June 22, 2023 16:59
@cipherboy cipherboy marked this pull request as ready for review June 22, 2023 17:00
@cipherboy cipherboy enabled auto-merge (squash) June 22, 2023 17:00
@cipherboy cipherboy merged commit 37e8651 into release/1.12.x Jun 22, 2023
@cipherboy cipherboy deleted the backport/cipherboy-fix-bug-setting-both-fields-false/vigorously-witty-mongoose branch June 22, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants