Backport of Remove readOnly attrs from Clients Count Config Serializer into release/1.13.x #21402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-17404/client-count-config-cleanup/terminally-trusting-snake
branch
from
3f90a66 to
93eec1b
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-17404/client-count-config-cleanup/terminally-trusting-snake
branch
from
f2d5744 to
965fbe5
Compare
…nt-config-cleanup/terminally-trusting-snake
zofskeez
approved these changes
Jun 22, 2023
VioletHynes
added
the
hashicorp-contributed-pr
Monkeychip
deleted the
backport/ui/VAULT-17404/client-count-config-cleanup/terminally-trusting-snake
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21391 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
I noticed in the flashMessage displayed after saving the config that the three attrs were mentioned. These are readOnly and thus do not need to be serialized. This is related to the census config work.
While I was in there, I "octane'ified" the serializer.
Backporting to last three supported versions, which misses the 1.11 which had this change. But this was not a functional bug, just cosmetic, so I think that is okay.
Overview of commits