Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming of enable_templating parameter #21319

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Fix naming of enable_templating parameter #21319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions website/content/api-docs/secret/pki.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3417,7 +3417,7 @@ parameter.
[RFC 5280 Section 4.2.2.1](https://datatracker.ietf.org/doc/html/rfc5280#section-4.2.2.1)
for information about the Authority Information Access field.

- `enable_aia_url_templating` `(bool: false)` - Specifies that the above AIA
- `enable_templating` `(bool: false)` - Specifies that the above AIA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 3426 '{{cluster_aia_path}}' is using quotes when I think it should be backticks?

URL values (`issuing_certificates`, `crl_distribution_points`, and
`ocsp_servers`) should be templated. This replaces the literal value
`{{issuer_id}}` with the ID of the issuer doing the issuance, the
Expand All @@ -3433,7 +3433,7 @@ parameter.

- `issuing_certificates={{cluster_aia_path}}/issuer/{{issuer_id}}/der`
- `crl_distribution_points={{cluster_aia_path}}/issuer/{{issuer_id}}/crl/der`
- `ocsp_servers={{cluster_path}}/ocsp`
- `ocsp_servers={{cluster_aia_path}}/ocsp`

~> **Note**: If no cluster-local address is present and templating is used,
issuance will fail.
Expand All @@ -3442,7 +3442,9 @@ parameter.

```json
{
"ocsp_servers": ["https://..."]
"issuing_certificates": ["{{cluster_aia_path}}/issuer/{{issuer_id}}/der"],
"crl_distribution_points": ["{{cluster_aia_path}}/issuer/{{issuer_id}}/crl/der"],
"ocsp_servers": ["{{cluster_aia_path}}/ocsp"]
}
```

Expand Down