-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAULT-17227 Add paths for seal config to cache exceptions. #21223
VAULT-17227 Add paths for seal config to cache exceptions. #21223
Conversation
Add barrierSealConfigPath and recoverySealConfigPlaintextPath to cacheExceptionsPaths in order to avoid a race that causes some nodes to always see a nil value.
|
||
// Add barrierSealConfigPath and recoverySealConfigPlaintextPath to the cache | ||
// exceptions to avoid unseal errors. See VAULT-17227 | ||
"core/seal-config", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than hard code the entries here, I could add a new method to Cache
to add entries to the cacheExceptions
. Should I do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the motivation?
|
Add paths for seal config to cache exceptions. Add barrierSealConfigPath and recoverySealConfigPlaintextPath to cacheExceptionsPaths in order to avoid a race that causes some nodes to always see a nil value.
Add paths for seal config to cache exceptions. Add barrierSealConfigPath and recoverySealConfigPlaintextPath to cacheExceptionsPaths in order to avoid a race that causes some nodes to always see a nil value. Co-authored-by: Victor Rodriguez <[email protected]>
Add paths for seal config to cache exceptions. Add barrierSealConfigPath and recoverySealConfigPlaintextPath to cacheExceptionsPaths in order to avoid a race that causes some nodes to always see a nil value.
Add paths for seal config to cache exceptions. Add barrierSealConfigPath and recoverySealConfigPlaintextPath to cacheExceptionsPaths in order to avoid a race that causes some nodes to always see a nil value. Co-authored-by: Victor Rodriguez <[email protected]>
Add barrierSealConfigPath and recoverySealConfigPlaintextPath to cacheExceptionsPaths in order to avoid a race that causes some nodes to always see a nil value.