UI: HDS adoption replace AlertBanner part 1 #21163
Conversation
hellobontempo
changed the base branch from
main
to
i/VAULT-16910/hds-adoption-replace-AlertBanner
| }} | ||
| </A.Description> | ||
| <A.Description class="has-top-margin-xs"> | ||
| <DocLink @path="/vault/tutorials/enterprise/hashicorp-enterprise-license"> |
There was a problem hiding this comment.
Not using the HDS standalone link with the goal being to use that component within <DocLink> itself
| @@ -1,4 +1,6 @@ | |||
| <AlertBanner @type="warning" class="is-marginless" @title="Vault is sealed" /> | |||
There was a problem hiding this comment.
didn't transfer is-marginless because HDS::Alert already is
| data-test-whitespace-warning | ||
| /> | ||
| </div> | ||
| <Hds::Alert |
There was a problem hiding this comment.
Removed div and css because looked fine without:
| {{/if}} | ||
| <NamespaceReminder @mode="edit" @noun="secret" /> |
There was a problem hiding this comment.
This being in the middle looked a little wild:
| 'MMM d, yyyy' | ||
| }}. Add a new license to your configuration and restart Vault." | ||
| class="message-marginless" | ||
| <div class="license-banner-wrapper"> |
| @message="You are creating a new version based on data from Version {{@model.selectedVersion.version}}. The current version for {{@model.id}} is Version {{@model.currentVersion}}." | ||
| /> | ||
| </div> | ||
| {{#if (or (eq @canReadSecretData false) this.isCreateNewVersionFromOldVersion)}} |
There was a problem hiding this comment.
combined banners into one message (pattern we used in client count dashboard)
| <A.Title>Warning</A.Title> | ||
| <A.Description> | ||
| This role has more than one | ||
| <code>credential_type</code>, currently: |
There was a problem hiding this comment.
thanks for adding this code block!
There was a problem hiding this comment.
thanks for noticing! I thought it was a nice touch! ✨
| @@ -329,10 +329,10 @@ module('Integration | Component | pki issuer cross sign', function (hooks) { | |||
| .dom(`${SELECTORS.signedIssuerRow()} [data-test-icon="alert-circle-fill"]`) | |||
| .exists('row has failure icon'); | |||
| assert | |||
| .dom('[data-test-alert-banner="alert"] .message-title') | |||
| .dom('[data-test-alert-banner] .message-title') | |||
There was a problem hiding this comment.
I'm wondering if we should have an alert SELECTORS file that contains common alert banner elements like [data-test-alert-banner] .message-title, [data-test-alert-banner] .alert-banner-message-body, [data-test-alert-banner]
There was a problem hiding this comment.
I'm glad you brought this up! I noticed in the past that general selectors tended to be harder to leverage in tests because they'd appear a bunch of times. Especially with components like alerts where multiple may appear on a page. I'm hoping to actually remove the general data-test-alert-banner all together and have each component reference a unique selector. Ideally this also makes debugging test easier!
hellobontempo
merged commit 247ddea
into
ui/VAULT-16910/hds-adoption-replace-AlertBanner
* UI: HDS adoption replace AlertBanner part 1 (#21163) * rename test selector * replace db banner * add class * replace db role edit * db creds * generate creds * simpler class * license banner component * oidc callback plash * raft * aws * secret create or update * change to compact alert for form field * change back to inline * combine alert banners * wrap in conditional * remove references to message class * UI: HDS adoption replace AlertBanner part 2 (#21243) * token expire warning * delete css * edit form * item details distribute mfa step 2 transit verify * back to secondary * distribute * oidc lease error * sign * kv obj and repl dash * more repl * update test selector * show, creds * shamir * pki csr * pki banners * add hds library to ember engines * woops comma * fix k8 test * update message error component for last! * hold off MessageError changes until next pr * revert test selectors * update pki tests * UI: part 3 remove alert banner (#21334) * final component swap * and actual final of MessageError * update MessageError selectors * delete alert-banner and remove references * update next step alerts to highlight color * finishing touches, auth form test and client dashboard inline link * fix more selectors * fix shamir flow test * ui: part 4 final cleanup (#21365) * replace AlertPopup * add test tag * move tag * one more message error tag * delete alert popup * final css cleanup * move preformatted flash into <p> tag * ui: address comments for sidebranch (#21388) * add periods, move link to trailing * more periods and typo fix
new component
old component