Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new policy metrics #21010

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Add new policy metrics #21010

merged 3 commits into from
Jun 7, 2023

Conversation

biazmoreira
Copy link
Contributor

Emit new metrics for policies

@biazmoreira biazmoreira requested review from kubawi and divyaac June 6, 2023 12:57
@biazmoreira biazmoreira force-pushed the biazmoreira/policy-metrics branch 2 times, most recently from 7be96a1 to 908ba66 Compare June 6, 2023 13:35
@biazmoreira biazmoreira force-pushed the biazmoreira/policy-metrics branch from 908ba66 to 4b32da4 Compare June 6, 2023 13:46
@biazmoreira biazmoreira added the core Issues and Pull-Requests specific to Vault Core label Jun 6, 2023
@biazmoreira biazmoreira added this to the 1.13.3 milestone Jun 6, 2023
@biazmoreira biazmoreira force-pushed the biazmoreira/policy-metrics branch from a9f1e5a to a652145 Compare June 6, 2023 13:56
Copy link
Contributor

@kubawi kubawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you might want to have someone a bit more experienced also have a look at the code 😄

changelog/21010.txt Outdated Show resolved Hide resolved
vault/core_metrics.go Outdated Show resolved Hide resolved
vault/core_metrics.go Outdated Show resolved Hide resolved
vault/core_metrics.go Outdated Show resolved Hide resolved
@divyaac
Copy link
Contributor

divyaac commented Jun 6, 2023

Should we add the new metrics to the telemetry doc? https://developer.hashicorp.com/vault/docs/internals/telemetry

@biazmoreira
Copy link
Contributor Author

Should we add the new metrics to the telemetry doc? https://developer.hashicorp.com/vault/docs/internals/telemetry

I will once this has been released!

@biazmoreira biazmoreira force-pushed the biazmoreira/policy-metrics branch from a652145 to 6fcd9a3 Compare June 7, 2023 09:16
@biazmoreira biazmoreira force-pushed the biazmoreira/policy-metrics branch from 6fcd9a3 to 8365fa4 Compare June 7, 2023 09:27
Copy link

@peteski22 peteski22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Bianca! 👍🏼

I added a few suggestions and random questions, if you wouldn't mind taking a look before merging.

vault/core_metrics.go Outdated Show resolved Hide resolved
vault/policy_store.go Outdated Show resolved Hide resolved
vault/policy_store.go Outdated Show resolved Hide resolved
vault/policy_store.go Outdated Show resolved Hide resolved
vault/policy_store.go Outdated Show resolved Hide resolved
vault/policy_store.go Outdated Show resolved Hide resolved
vault/core_metrics.go Outdated Show resolved Hide resolved
vault/core_metrics.go Outdated Show resolved Hide resolved
@biazmoreira biazmoreira requested a review from peteski22 June 7, 2023 10:55
@biazmoreira biazmoreira force-pushed the biazmoreira/policy-metrics branch 4 times, most recently from 3ff77ea to 815f7dd Compare June 7, 2023 11:05
Copy link

@peteski22 peteski22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@biazmoreira biazmoreira force-pushed the biazmoreira/policy-metrics branch from 815f7dd to d85fea1 Compare June 7, 2023 11:15
@biazmoreira biazmoreira force-pushed the biazmoreira/policy-metrics branch from d85fea1 to c0b7948 Compare June 7, 2023 11:15
@biazmoreira biazmoreira merged commit aca58d8 into main Jun 7, 2023
@biazmoreira biazmoreira deleted the biazmoreira/policy-metrics branch June 7, 2023 13:19
@mladlow mladlow removed this from the 1.13.3 milestone Jun 16, 2023
@mladlow
Copy link
Collaborator

mladlow commented Jun 16, 2023

@biazmoreira when you're back let's talk about what releases this should go in. I cleared the 1.13.3 milestone because it definitely won't be in that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues and Pull-Requests specific to Vault Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants