-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new policy metrics #21010
Add new policy metrics #21010
Conversation
7be96a1
to
908ba66
Compare
908ba66
to
4b32da4
Compare
a9f1e5a
to
a652145
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you might want to have someone a bit more experienced also have a look at the code 😄
Should we add the new metrics to the telemetry doc? https://developer.hashicorp.com/vault/docs/internals/telemetry |
I will once this has been released! |
a652145
to
6fcd9a3
Compare
6fcd9a3
to
8365fa4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Bianca! 👍🏼
I added a few suggestions and random questions, if you wouldn't mind taking a look before merging.
3ff77ea
to
815f7dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
815f7dd
to
d85fea1
Compare
d85fea1
to
c0b7948
Compare
@biazmoreira when you're back let's talk about what releases this should go in. I cleared the 1.13.3 milestone because it definitely won't be in that one. |
Emit new metrics for policies