Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: Fix bug with 'cache' stanza validation #20934

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Conversation

averche
Copy link
Contributor

@averche averche commented Jun 1, 2023

There is a bug with agent config validation where an empty cache {} is rejected for any template configuration files:

 validation error: configuring the api_proxy requires at least 1 listener to be defined

This PR addresses the issue by not initializing an &APIProxy{...} config unless cache has the corresponding flags set.

@averche averche added this to the 1.14 milestone Jun 1, 2023
@VioletHynes
Copy link
Contributor

Thank you for fixing this! I think the backport only needs to go back to 1.13, since that's when we introduced the API Proxy stanza.

@averche averche enabled auto-merge (squash) June 1, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants