agent: Add implementation for injecting secrets as environment variables to vault agent cmd #20739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anton Averchenkov <[email protected]>
Co-authored-by: Anton Averchenkov <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Co-authored-by: Anton Averchenkov <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Co-authored-by: Anton Averchenkov <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
…o agent-runner-env-var
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Co-authored-by: Anton Averchenkov <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
dhuckins
changed the title
averche
approved these changes
May 24, 2023
Comment on lines
27
to
+34
| "github.com/hashicorp/go-secure-stdlib/reloadutil" | ||
| "github.com/kr/pretty" | ||
| "github.com/mitchellh/cli" | ||
| "github.com/oklog/run" | ||
| "github.com/posener/complete" | ||
| "golang.org/x/text/cases" | ||
| "golang.org/x/text/language" | ||
| "google.golang.org/grpc/test/bufconn" |
There was a problem hiding this comment.
Nit: seems like hashicorp imports got mixed with other imports
There was a problem hiding this comment.
still counted as "third-party" I suppose...
Comment on lines
+792
to
+801
| g.Add(func() error { | ||
| return es.Run(ctx, ah.ExecTokenCh) | ||
| }, func(err error) { | ||
| // Let the lease cache know this is a shutdown; no need to evict | ||
| // everything | ||
| if leaseCache != nil { | ||
| leaseCache.SetShuttingDown(true) | ||
| } | ||
| cancelFunc() | ||
| }) |
There was a problem hiding this comment.
This is a very strange pattern but I guess we have to stick with it 😄
Signed-off-by: Daniel Huckins <[email protected]>
Signed-off-by: Daniel Huckins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR runs the exec server (#20628) with the vault agent command
It is part of the larger effort to add environment variable support within Vault Agent (VLT-253).