UI: updates info table row jsdoc #20697
Conversation
| @@ -6,23 +6,17 @@ | |||
| import { helper } from '@ember/component/helper'; | |||
| import { formatDuration, intervalToDuration } from 'date-fns'; | |||
|
|
|||
| export function duration([time], { nullable = false }) { | |||
There was a problem hiding this comment.
nullable = false was only used by transit, which is removed now
There was a problem hiding this comment.
Sometimes the API returns Duration strings (like 10m) and sometimes it turns a number, which is the duration value in seconds. I think if we want to update the TTL values to the full unit we should do it consistently for durations like 10m as well.
In the TTL picker component we use the library @icholy/duration to parse the given duration if it exists. This might be a good moment to pull some of that parsing into a util that can be shared between the display helper and the component for choosing the TTL
| return Duration.parse(duration).seconds(); | ||
| } catch (e) { | ||
| // return false so parent can decide how to handle parsing error | ||
| return false; |
There was a problem hiding this comment.
Parent should probably check === some value rather than falsey (!returnedSeconds) since the valid duration 0 would be falsey. So I would return null instead but that's just me
There was a problem hiding this comment.
I went back and forth between having null here and couldn't decide since they're both false. But that's a good point! Thank you
TTL duration values will now universally read with their expanded unit, instead of the letter abbreviation. For example,
30 secondsinstead of30s