Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly validate int ca lifetime error, add warning on leaf cert with basic constraints #20654

Merged
merged 3 commits into from
May 19, 2023
Merged

Properly validate int ca lifetime error, add warning on leaf cert with basic constraints #20654

merged 3 commits into from
May 19, 2023

Conversation

cipherboy
Copy link
Contributor

  • In the tests, make sure we validate the expected error message; over time, the role definition changed to prevent issuance of this ICA leaf.
  • Add warning when issuing a leaf cert that looks like it could be an intermediate (has any basic constraint extension).

In the future, we might move to forbidding issuance of leaf certs from CSRs that contain asserted IsCA basic constraints.

@cipherboy cipherboy added this to the 1.14 milestone May 18, 2023
@cipherboy cipherboy requested review from kitography, stevendpclark and a team May 18, 2023 16:09
@cipherboy
Add changelog entry
6fcf821 
Signed-off-by: Alexander Scheel <[email protected]>
@cipherboy cipherboy enabled auto-merge (squash) May 18, 2023 18:54
@cipherboy cipherboy merged commit 9055b93 into main May 19, 2023
@cipherboy cipherboy deleted the cipherboy-properly-validate-int-ca-lifetime-error branch May 19, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendpclark stevendpclark stevendpclark approved these changes

@kitography kitography Awaiting requested review from kitography

Assignees
No one assigned
Labels
secret/pki
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
2 participants
@cipherboy @stevendpclark