Backport of Correct Default for MaximumPageSize into release/1.11.x #20637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ldap-max-page-default/partly-fine-starfish
branch
from
ff612a7 to
15cde29
Compare
|
|
ltcarbonell
force-pushed
the
backport/ldap-max-page-default/partly-fine-starfish
branch
from
c22f959 to
d5f1abd
Compare
ltcarbonell
force-pushed
the
backport/ldap-max-page-default/partly-fine-starfish
branch
from
d5f1abd to
dfe6e07
Compare
* default max page size for config * Add changelog * update test int to *int * add testing defaults * update default to -1, i.e. dont paginate * update test * Add error message for invalid search * Make 0 the default * cleanup * Add to known issues doc * Update website/content/docs/upgrading/upgrade-to-1.13.x.mdx * Update website/content/docs/upgrading/upgrade-to-1.11.x.mdx Co-authored-by: Jason O'Donnell <[email protected]> * Update website/content/docs/upgrading/upgrade-to-1.13.x.mdx Co-authored-by: Jason O'Donnell <[email protected]> * Update website/content/docs/upgrading/upgrade-to-1.12.x.mdx Co-authored-by: Jason O'Donnell <[email protected]> * Add workaround to docs * Update changelog/20453.txt Co-authored-by: Austin Gebauer <[email protected]> --------- Co-authored-by: Jason O'Donnell <[email protected]> Co-authored-by: Austin Gebauer <[email protected]>
ltcarbonell
force-pushed
the
backport/ldap-max-page-default/partly-fine-starfish
branch
from
dfe6e07 to
bb65cfb
Compare
ltcarbonell
approved these changes
May 17, 2023
ltcarbonell
approved these changes
May 17, 2023
ltcarbonell
deleted the
backport/ldap-max-page-default/partly-fine-starfish
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20453 to be assessed for backporting due to the inclusion of the label backport/1.11.x.
🚨
The person who merged in the original PR is:
@ltcarbonell
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
This pull request addresses a problem that was introduced in a previous pull request (#19032). The earlier PR added a new configuration option called max_page_size to the LDAP secret engine. This option allows users to adjust the size of the paged search results. By default, it is set to 2147483647 (math.MaxInt32), but it can also be set to -1 to use non-paged searching.
The issue occurs when upgrading Vault to 1.13.2, 1.12.6, or 1.11.10, that has an existing LDAP Auth configuration. This would result in the
max_page_sizebeing set to 0 instead of the intended default of 2147483647.Resolves #20416
Overview of commits